-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible: add ICU to sharedlibs containers #2677
Conversation
Add versions of ICU to the sharedlibs containers. Intended to be used to build and test Node.js against a system ICU: e.g. for ICU 65 ``` $ export PKG_CONFIG_PATH=$ICU65DIR/lib/pkgconfig $ export LD_LIBRARY_PATH=$(pkg-config --variable=libdir icu-i18n) $ export CONFIG_FLAGS='--with-intl=system-icu --verbose' $ make run-ci ```
This is deployed onto the containers on
I've not made any CI job changes yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's some opportunities for some clever bash in here, but maybe keeping it simple-ish is good enough
are we going to add regular jobs for each of these? we're going to need to have a hard look at capacity I think
Admittedly I didn't try but the docs for
My initial thought was to add one job (well subjob of the linux-containered job) that would parse out the minimum ICU version from The other way we could do it is to test as many versions of ICU as possible (i.e. a new subjob for each ICU version and then VersionSelector.groovy to filter them by release line) but that will be more maintenance for the Build team (keeping VersionSelector.groovy updated, managing several icu* labels in Jenkins) and would be several new (sub)jobs which I would then share your concerns over capacity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add versions of ICU to the sharedlibs containers. Intended to be used
to build and test Node.js against a system ICU:
e.g. for ICU 65